Optimism plugin #6146
Merged
Optimism plugin #6146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/Nethermind/Nethermind.Merge.Plugin/EngineRpcModule.Paris.cs
This reverts commit 0c8c091.
deffrian
requested review from
MarekM25,
emlautarom1,
rubo,
flcl42 and
LukaszRozmej
src/Nethermind/Nethermind.Consensus/Nethermind.Consensus.csproj
Outdated
Show resolved
Hide resolved
|
|
||
| IEnumerable<Transaction> txs = _payloadAttrsTxSource.GetTransactions(parent, attrs.GasLimit, attrs); | ||
|
|
||
| Block block = new(blockHeader, txs, Array.Empty<BlockHeader>(), payloadAttributes?.Withdrawals); |
There was a problem hiding this comment.
Compiler can't understand that and fails with warning as error
|
|
||
| public Task InitNetworkProtocol() => Task.CompletedTask; | ||
|
|
||
| public Task InitSynchronization() |
There was a problem hiding this comment.
WHy do we have to init synchronization?
There was a problem hiding this comment.
we would initialize syncronization anyways in the default InitializeNetwork, at least this one would work if p2p was enabled in Optimism.
Comment on lines
+52
to
+59
| if (!WorldState.AccountExists(tx.SenderAddress!)) | ||
| { | ||
| WorldState.CreateAccount(tx.SenderAddress!, 0, 1); | ||
| } | ||
| else | ||
| { | ||
| WorldState.IncrementNonce(tx.SenderAddress!); | ||
| } |
There was a problem hiding this comment.
A bit of hack that Validate mutates the state
There was a problem hiding this comment.
I would love to push it to the next pr. Will require refactoring
There was a problem hiding this comment.
let's also capture this in an issue
This was referenced Oct 25, 2023
|
I created three issues. |
LukaszRozmej
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Nethermind optimism plugin
Changes
DisableGcOnNewPayload. During sync disabling gc causes memory leakstateUnavailable. Op-mainnet and op-goerli don't have state for block number zero.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
Requires explanation in Release Notes