Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for state override parameter in some RPC methods #7362

Merged
merged 86 commits into from
Nov 1, 2024

Conversation

alexb5dh
Copy link
Contributor

@alexb5dh alexb5dh commented Aug 26, 2024

Resolves #4021, resolves #6120, resolves #7306.

Changes

  • Support for state override set in the following RPC methods:
    • eth_call, eth_estimategas
    • trace_call
    • debug_traceCall
  • Makes following methods to run on top of the specified block instead of the previous one, similar to other clients:
    • trace_call, trace_callMany, trace_rawTransaction
    • debug_traceCall
  • Use corresponding factory to create module for TraceRpcModuleTests and DebugRpcModuleTests - to make it more consistent with regular setup.
  • Fixes double-serialization of some of the parameters in the RPC tests.

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • Yes

Documentation

Requires documentation update

  • Yes

Requires explanation in Release Notes

  • Yes, RPC changes should probably be included.

@alexb5dh alexb5dh self-assigned this Aug 26, 2024
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@OlegJakushkin OlegJakushkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! solves some issues on StateRoot in eth_simulate.

@alexb5dh alexb5dh merged commit 26a2e89 into master Nov 1, 2024
75 checks passed
@alexb5dh alexb5dh deleted the feature/rpc-state-override branch November 1, 2024 03:42
@kamilchodola kamilchodola restored the feature/rpc-state-override branch November 4, 2024 14:01
@alexb5dh alexb5dh deleted the feature/rpc-state-override branch November 4, 2024 14:56
@alexb5dh alexb5dh restored the feature/rpc-state-override branch November 4, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants