Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/network di #7520

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Feature/network di #7520

wants to merge 20 commits into from

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Oct 1, 2024 •
edited
Loading

  • Move all network components to use dependency injection.
  • Added void ConfigureSynchronizationBuilder(ContainerBuilder containerBuilder); so that plugin can configure the container specificatlly for the network component.
  • OptimismPlugin uses merge's MergeNetworkModule.
  • Added ConfigRegistrationSource.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

@asdacap asdacap mentioned this pull request Oct 18, 2024
Draft
16 tasks
@asdacap asdacap marked this pull request as ready for review October 29, 2024 12:55
@asdacap asdacap requested a review from rubo as a code owner October 29, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubo rubo Awaiting requested review from rubo rubo is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@asdacap