Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Tasks collections in .Net 9 #7585

Draft
wants to merge 5 commits into
base: feature/dotnet9-migration
Choose a base branch
from

Conversation

LukaszRozmej
Copy link
Member

Builds upon #7532

Changes

  • Move task collections to pooled ones and use spans when using WaitAll, WhenAll and WhenAny

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: In some places we add items to the pool in a for loop with .Add(), in other places, with LINQ's .Select() or Enumerable.Range().Select(). Isn't it worth unifying the approach?

@LukaszRozmej LukaszRozmej mentioned this pull request Oct 31, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants