Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log request on invalid RPC JSON #7621

Merged
merged 23 commits into from
Oct 29, 2024
Merged

Log request on invalid RPC JSON #7621

merged 23 commits into from
Oct 29, 2024

Conversation

alexb5dh
Copy link
Contributor

@alexb5dh alexb5dh commented Oct 16, 2024 •
edited
Loading

Changes

Log RPC request data (sliced to 1000 chars) if it's not a valid JSON.

Example (first logged using ERROR level, then with request body at DEBUG): image

Types of changes

What types of changes does your code introduce?

  • Other: Additional logs

Testing

Requires testing

  • No

Documentation

Requires documentation update

  • No

Requires explanation in Release Notes

  • No

@alexb5dh alexb5dh self-assigned this Oct 16, 2024
@alexb5dh alexb5dh marked this pull request as ready for review October 25, 2024 10:29
@LukaszRozmej LukaszRozmej merged commit 6a08dd5 into master Oct 29, 2024
75 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/handle-rpc-json-error branch October 29, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@kamilchodola kamilchodola kamilchodola approved these changes

@benaadams benaadams benaadams approved these changes

Assignees

@alexb5dh alexb5dh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexb5dh @benaadams @LukaszRozmej @kamilchodola