Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/Separate block store and Bad block store #7659

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Refactor/Separate block store and Bad block store #7659

merged 4 commits into from
Oct 28, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Oct 26, 2024 •
edited
Loading

  • Extract IBadBlockStore from IBlockStore.
  • Otherwise things will get confusing with a different/multiple format for block storage.

Types of changes

What types of changes does your code introduce?

  • Refactoring

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Remarks

  • Almost made a KV<T> but thought.. nah.

@asdacap asdacap mentioned this pull request Oct 28, 2024
Merged
6 tasks
@asdacap asdacap marked this pull request as ready for review October 28, 2024 02:33
LukaszRozmej
LukaszRozmej approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't really see the need, but I don't see any harm either. So if it makes it simpler for you.

@asdacap asdacap merged commit a5526b1 into master Oct 28, 2024
75 checks passed
@asdacap asdacap deleted the refactor/separate-block-store branch October 28, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asdacap @LukaszRozmej