Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove AccountStateJson, refactor BeaconBlockRootHandler #7674

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

yerke26
Copy link
Contributor

@yerke26 yerke26 commented Oct 28, 2024

General refactoring before t8n, to make review changes easier to review

Changes

  • removed unnecessary AccountStateJson.
  • Added ITxTracer parameter to BeaconBlockRootHandler to be able to trace storage changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

@yerke26 yerke26 merged commit 089d2c4 into master Oct 28, 2024
75 checks passed
@yerke26 yerke26 deleted the refactoring/ethereum-tests branch October 28, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants