Receipts: Add option to not recover sender and write flags #7680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asdacap
changed the title
LukaszRozmej
approved these changes
Oct 30, 2024
| @@ -9,7 +9,7 @@ namespace Nethermind.Blockchain.Receipts | |||
| public interface IReceiptFinder | |||
| { | |||
| Hash256? FindBlockHash(Hash256 txHash); | |||
| TxReceipt[] Get(Block block, bool recover = true); | |||
| TxReceipt[] Get(Block block, bool recover = true, bool recoverSender = true); | |||
There was a problem hiding this comment.
Maybe would be better to collapse recover and recoverSender into an enum?
public enum ReceiptRecoveryOptions { None, TransactionAndBlock, TransactionAndBlockWithSender }
Hard to name
There was a problem hiding this comment.
I'd say, don't recover sender at all in receipt finder. Its a weird behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?