Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/hidden cli option not detected #7697

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fix/hidden cli option not detected #7697

merged 2 commits into from
Nov 1, 2024

Conversation

asdacap
Copy link
Contributor

@asdacap asdacap commented Nov 1, 2024

  • Fix hidden cli args not used at all.

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • Yes

If yes, did you write tests?

  • No

Notes on testing

  • Tested manually.

@asdacap asdacap requested a review from rubo November 1, 2024 01:20
LukaszRozmej
LukaszRozmej approved these changes Nov 1, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it looked fishy to me: #7653 (comment)

@asdacap asdacap merged commit d2f4b15 into master Nov 1, 2024
75 checks passed
@asdacap asdacap deleted the fix/hidden-cli-option-not-detected branch November 1, 2024 10:13
@rubo
Copy link
Contributor

rubo commented Nov 1, 2024

Yeah it looked fishy to me: #7653 (comment)

Yeah, my bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@rubo rubo Awaiting requested review from rubo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asdacap @rubo @LukaszRozmej