Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client id to admin_peers RPC API #7717

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

LukaszRozmej
Copy link
Member

Replaces #7706

Add client id to admin_peers RPC API

Related #7536

Changes

  • Add id to admin_peers RPC API
  • Update clientId -> name

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Screenshots

Screenshot 2024-11-04 at 13 42 38

Notes

Regarding updating the clientId parameter to name, I believe that refers to the client name. However, I've only updated it in the admin_peers RPC API, keeping clientId unchanged in other functions.

@LukaszRozmej LukaszRozmej merged commit 02a14a0 into master Nov 5, 2024
77 checks passed
@LukaszRozmej LukaszRozmej deleted the pr/n7706_add-client-id branch November 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants