Feature/unified plugin Enabled flag

[asdacap]

• Add Enabled property to INethermindPlugin.
  • Replace IInitializationPlugin.ShouldRunSteps.
  • Replace IConsensusWrapperPlugin.Enabled.
  • Replace IConsensusPlugin.SealEngineType check.
• To allow plugins to know if it should be enabled, they are given access to IConfigs and ChainSpec from their constructor.
• Plugins that return false on Enabled is immediately disposed and not added as part of plugin list. No need to check if it enabled manually in Init as that won't be called..

Types of changes

What types of changes does your code introduce?

• New feature (a non-breaking change that adds functionality)

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

• Testing...

[LukaszRozmej]

no need to discriminate by engine type?

[asdacap]

Still not sure, but each plugin seems too be exclusive to each other. They do exactly the same check, just check with chainSpec.sealEngineType.

[asdacap]

I'd say, do a check tto make sure only one IConsensusPlugin is on.

[LukaszRozmej]

I wonder do we need IInitializationPlugin type at all and just scan all enabled plugins assemblies?

[asdacap]

We actually do. Because it replaces ISteps.

[LukaszRozmej]

Yeah but we use it to filter out plugin assemblies where we look for ISteps, maybe just look for ISteps in all plugin assemblies and then we don't need it?

[asdacap]

You mean just assume all INethermindPlugin is IInitializationPlugin?

[LukaszRozmej]

yes, not sure if worth it, it will potentially add a bit to startup time? Would be good to make assemblies inspections in parallel in EthereumStepsLoader.LoadSteps?

[LukaszRozmej]

I think if we change in EthereumStepsLoader:

            List<Type> allStepTypes = new List<Type>();
            foreach (Assembly stepsAssembly in _stepsAssemblies)
            {
                allStepTypes.AddRange(stepsAssembly.GetExportedTypes()
                    .Where(t => !t.IsInterface && !t.IsAbstract && IsStepType(t)));
            }

            return allStepTypes
                .Select(s => new StepInfo(s, GetStepBaseType(s)))
                .GroupBy(s => s.StepBaseType)
                .Select(g => SelectImplementation(g.ToArray(), apiType))
                .Where(s => s is not null)
                .Select(s => s!);

to

            List<Type> allStepTypes = _stepsAssemblies
                .AsParallel()
                // .AsOrdered()  Not sure if needed, probably not
                .SelectMany(a => a.GetExportedTypes())
                .Where(t => t is { IsInterface: false, IsAbstract: false } && IsStepType(t))
                .ToList();

            return allStepTypes
                .AsParallel()
                // .AsOrdered()  Not sure if needed, probably not
                .Select(s => new StepInfo(s, GetStepBaseType(s)))
                .GroupBy(s => s.StepBaseType)
                .Select(g => SelectImplementation(g.ToArray(), apiType))
                .Where(s => s is not null)
                .Select(s => s!);

this should be fine?

potentially we can even not allocate list

            IEnumerable<Type> allStepTypes = _stepsAssemblies
                .AsParallel()
                // .AsOrdered()  Not sure if needed, probably not
                .SelectMany(a => a.GetExportedTypes())
                .Where(t => t is { IsInterface: false, IsAbstract: false } && IsStepType(t));

            return allStepTypes
                .AsParallel()
                // .AsOrdered()  Not sure if needed, probably not
                .Select(s => new StepInfo(s, GetStepBaseType(s)))
                .GroupBy(s => s.StepBaseType)
                .Select(g => SelectImplementation(g.ToArray(), apiType))
                .Where(s => s is not null)
                .Select(s => s!);

[asdacap]

Not exactly related with this pr. The IInitializationPlugin is about picking _stepsAssemblies. Another idea (that I would rather have) is to have an explicit IEnumerable<Type> IInitializationPlugin.GetSteps() which should make it clear, what does it do exactly.

[asdacap]

Took 24ms to look for all assembly.