Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Gnosis test runner #8102

Merged
merged 3 commits into from
Jan 29, 2025
Merged

add Gnosis test runner #8102

merged 3 commits into from
Jan 29, 2025

Conversation

yerke26
Copy link
Contributor

@yerke26 yerke26 commented Jan 24, 2025

Fixes Closes Resolves #

Currently Nethermind BlockchainTestRunner and StateTestRunner does not support running gnosis tests. These changes supports running gnosis tests

Changes

  • add new flag -g (gnosisTest) flag to Nethermind.Test.Runner,
  • if -g flag exists then chainId = 100 for gnosis
  • add GnosisSpecProvider

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are gnosisBlockchainTest1.json and gnosisStateTest.json needed?

@yerke26
Copy link
Contributor Author

yerke26 commented Jan 24, 2025

Are gnosisBlockchainTest1.json and gnosisStateTest.json needed?

I'll add sample tests later, but for now I'll remove these files

@yerke26 yerke26 merged commit e8707e6 into master Jan 29, 2025
79 checks passed
@yerke26 yerke26 deleted the feature/gnosis-test-runner branch January 29, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants