Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements and documents the
get_user_prediction()stub for the frontend to show a user's position in a market.Closes #66
Changes
get_user_prediction()incontracts/contracts/boxmeout/src/market.rs:UserPredictionResultwith:commitment_hash— commitment hash when committed; zeros after revealamount— committed/revealed amountstatus—PREDICTION_STATUS_COMMITTED(0) orPREDICTION_STATUS_REVEALED(1)predicted_outcome— 0 (NO) or 1 (YES) when revealed;PREDICTION_OUTCOME_NONE(2) when committedNonewhen the user has no prediction (no commitment and no revealed prediction).market.rs):test_get_user_prediction_no_prediction_returns_nonetest_get_user_prediction_committed_returns_commitment_datatest_get_user_prediction_revealed_returns_prediction_datatest_get_user_prediction_revealed_no_outcomecontracts/contracts/boxmeout/tests/market_test.rs.Acceptance criteria
commitment_hash,amount,status,predicted_outcome(if revealed)None) when user has no predictionI did not change or add get_user_prediction(). It was already implemented in contracts/contracts/boxmeout/src/market.rs (around lines 546–570), and the unit tests were already in market.rs (around lines 1101–1153
How to test