feat: Verify and document get_market_liquidity implementation#152
Merged
GoSTEAN merged 3 commits intoNetwalls:mainfrom Feb 21, 2026
Merged
feat: Verify and document get_market_liquidity implementation#152GoSTEAN merged 3 commits intoNetwalls:mainfrom
GoSTEAN merged 3 commits intoNetwalls:mainfrom
Conversation
added 3 commits
February 20, 2026 22:51
- Confirmed get_market_liquidity function is fully implemented in market.rs - Returns YES/NO reserves, k constant, and implied odds - Comprehensive unit tests covering all edge cases - Resolved merge conflicts in factory_test.rs - Added conflict resolution summary documentation Acceptance Criteria Met: ✅ Return current YES/NO liquidity from AMM pool ✅ Return k constant and implied odds ✅ Unit tests with 12 comprehensive test cases
- Removed stray merge conflict markers (=======, >>>>>>> origin/main) at line 1103 - This was causing CI build failure with 'expected item, found ==' error - All test functions are now properly closed
Contributor
|
resolve conflict @utilityjnr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria Met:
✅ Return current YES/NO liquidity from AMM pool
✅ Return k constant and implied odds
✅ Unit tests with 12 comprehensive test cases