-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(repeater): rename experimental-connection-reuse to ntlm #499
feat(repeater): rename experimental-connection-reuse to ntlm #499
Conversation
@mongoose79 please follow the contributing guide:
|
PAP-421 #code-review
821fc07
to
321b719
Compare
- `ntlm` alias has been added to `experimental-connection-reuse`.
- A new issue has been created: https://github.com/NeuraLegion/bright-cli/issues/500
- A new issue is created: https://github.com/NeuraLegion/bright-cli/issues/500
+ closes #500 @mongoose79 fyi |
Co-authored-by: Artem Derevnjuk <artem.derevnjuk@brightsec.com>
…tps://github.com/NeuraLegion/bright-cli into fix/rename-experimental-connection-reuse-to-ntlm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bright-cli/src/Commands/RunRepeater.ts
Line 182 in a24e28e
reuseConnection: !!args.experimentalConnectionReuse, |
reuseConnection: !!args.ntlm || !!args.experimentalConnectionReuse,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
The
experimental-connection-reuse
option has been deprecated.closes #500