Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(repeater): adjust error message #501

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

mongoose79
Copy link
Contributor

No description provided.

@mongoose79 mongoose79 added the Type: bug Something isn't working. label Nov 19, 2023
@mongoose79 mongoose79 requested a review from derevnjuk November 19, 2023 13:17
@mongoose79 mongoose79 self-assigned this Nov 19, 2023
@derevnjuk
Copy link
Member

derevnjuk commented Nov 20, 2023

@mongoose79 please change the base branch to the next. Additionally, adjust the commit type and label to reflect the essence of the changes made (this is refactor or feat rather than fix)

@mongoose79 mongoose79 changed the base branch from master to next November 20, 2023 08:48
@mongoose79 mongoose79 added Type: refactoring Changes in the way the code works internally without changing the output produced. and removed Type: bug Something isn't working. labels Nov 20, 2023
@mongoose79 mongoose79 changed the title fix(repeater): adjust error message refactor(repeater): adjust error message Nov 20, 2023
Copy link
Collaborator

@denis-maiorov-brightsec denis-maiorov-brightsec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@denis-maiorov-brightsec denis-maiorov-brightsec merged commit 1d8ed3b into next Nov 20, 2023
4 checks passed
@denis-maiorov-brightsec denis-maiorov-brightsec deleted the fix/adjust-repeater-error-message branch November 20, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: refactoring Changes in the way the code works internally without changing the output produced.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants