-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade minimum node version to 20 #628
Conversation
also update the E2E test workflows
@maksadbek this contradicts the requirements. We are committed to supporting last 3 LTS versions (e.g., 18, 20, 22). Your changes could be harmful from both a product and dev perspective, as many workflows in Bright still rely on v18 (and can rely until the end of April) |
We're still going to support v12 which is using node 18. I'm fine with dropping support from v13, which we're planning actively on pushing customers to upgrade to. |
Also, please update the documentation. We have already dropped support for Linux 3.9 and are planning to do the same for Node v18 (as we have already done for versions 14, 16, etc.) |
This is part of the ask I made to help me with fresh data so I can update the guide :) |
@adirdidi there are ton of Linux flavors, so we cannot specify just one (e.g., Ubuntu v20) and assume that there are same equivalent for Fedora/Debian/etc. IMHO using the Linux kernel version is a more preferable and common. Even the kernel might not be sufficient CLI depends on the specific version of the C library (such as glibc, musl, etc.) as well. So, it is better to use specific kernel versions and versions of glibc/musl. Or if you prefer to specify distros, just simply say that we support only the N latest releases of A, B, and C OSes Currently, we support >= linux kernel 4.18, glibc 2.28, and musl 1.1.24. This is equivalent to >= RHEL8, Ubuntu 20.04 (or 18.04, need to check), Debian 10, Alpine Linux 3.10. MacOS and Windows remain as in the screenshot above. |
While there are many indeed, the plan is to only specify the major ones (which I'm fine with the 4 you've specified). We can keep the 'raw' requirements if they want to use something else - but I think that enterprises won't go with something which is not one of the 4. |
Co-authored-by: Artem Derevnjuk <artem.derevnjuk@brightsec.com>
Co-authored-by: Artem Derevnjuk <artem.derevnjuk@brightsec.com>
also update the E2E test workflows