feat(repeater): refrain from utilizing non standard ports #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit e2cd7e1 and detected 7 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 85.9% (50% is the threshold). This pull request will bring the total coverage in the repository to 94.9% (-2.6% change). View more on Code Climate. |
ostridm
force-pushed
the
feat_#196/replace-rmq-with-web-sockets
branch
from
87f0726 to
7aec236
Compare
derevnjuk
changed the title
derevnjuk
requested changes
May 31, 2024
derevnjuk
requested changes
Jun 14, 2024
packages/repeater/src/utils/NormalizeZlibDeflateTransformStream.spec.ts
Outdated
Show resolved
Hide resolved
packages/repeater/src/utils/NormalizeZlibDeflateTransformStream.spec.ts
Outdated
Show resolved
Hide resolved
packages/repeater/src/request-runner/protocols/HttpRequestRunner.ts
Outdated
Show resolved
Hide resolved
packages/repeater/src/request-runner/protocols/HttpRequestRunner.spec.ts
Show resolved
Hide resolved
packages/repeater/src/request-runner/protocols/HttpRequestRunner.spec.ts
Outdated
Show resolved
Hide resolved
|
@ostridm, we should agree to stop using term "Bus" in context of Bridges service. |
derevnjuk
requested changes
Jun 19, 2024
derevnjuk
reviewed
Jun 19, 2024
…mq-with-web-sockets
derevnjuk
requested changes
Jun 19, 2024
derevnjuk
approved these changes
Jun 19, 2024
This was referenced Jul 20, 2024
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #196