Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bus): get rid of amqp event bus #198

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Jun 11, 2024

closes #196

Copy link

gitguardian bot commented Jun 11, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11416025 Triggered Generic Password afadab5 packages/bus/src/dispatchers/DefaultRMQConnectionManager.spec.ts View secret
11416025 Triggered Generic Password afadab5 packages/bus/src/dispatchers/DefaultRMQConnectionManager.spec.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@ostridm ostridm force-pushed the feat_#196/get-rid-of-amqp-bus branch 3 times, most recently from b9fcf75 to afadab5 Compare June 11, 2024 09:23
@ostridm ostridm marked this pull request as ready for review June 12, 2024 06:18
@ostridm ostridm requested a review from derevnjuk June 12, 2024 06:18
@ostridm ostridm self-assigned this Jun 12, 2024
@ostridm ostridm added the Type: enhancement New feature or request. label Jun 12, 2024
Copy link
Member

@derevnjuk derevnjuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same comments and reservations apply as in sectester-net

@ostridm ostridm force-pushed the feat_#196/get-rid-of-amqp-bus branch from cd6bb7a to 02aa6e4 Compare June 18, 2024 13:59
@ostridm ostridm requested a review from derevnjuk June 18, 2024 14:02
derevnjuk
derevnjuk previously approved these changes Jun 19, 2024
@derevnjuk derevnjuk marked this pull request as draft June 19, 2024 06:59
Base automatically changed from feat_#196/replace-rmq-with-web-sockets to master June 19, 2024 12:21
@derevnjuk derevnjuk dismissed their stale review June 19, 2024 12:21

The base branch was changed.

@derevnjuk
Copy link
Member

@ostridm please rebase onto the main

BREAKING CHANGE: The `sectester/bus` package, which was intended
to provide support of communication via the AMQP transport is removed.
This change simplifies the codebase by removing deprecated options and
encourages the use of more modern and supported transport methods.

closes #196
@ostridm ostridm force-pushed the feat_#196/get-rid-of-amqp-bus branch from 02aa6e4 to a307ed1 Compare June 19, 2024 13:09
@ostridm ostridm marked this pull request as ready for review June 19, 2024 13:09
@ostridm ostridm requested a review from derevnjuk June 19, 2024 13:11
Copy link

codeclimate bot commented Jun 19, 2024

Code Climate has analyzed commit a307ed1 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.3%.

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridges service integration
2 participants