fix: removed async auth calls #363
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenJacobs61
added
the
version:patch
StevenJacobs61
force-pushed
the
fix/removed-async-auth-lookups
branch
from
378aace to
5027112
Compare
StevenJacobs61
changed the title
favour-neuraco
requested changes
Feb 5, 2026
| logger.info("Access token expired, refreshing token") | ||
| await loop.run_in_executor(None, auth.login) | ||
| headers = await loop.run_in_executor(None, auth.get_headers) | ||
| auth.login() |
Contributor
There was a problem hiding this comment.
Auth.login() is blocking. Calling it synchronously from async code will block the event loop and can stall uploads or progress reporting. Please run login off the event loop again (eg await asyncio.to_thread(auth.login) or executor).
| logger.info("Access token expired, refreshing token") | ||
| await loop.run_in_executor(None, auth.login) | ||
| headers = await loop.run_in_executor(None, auth.get_headers) | ||
| auth.login() |
Contributor
There was a problem hiding this comment.
same comment as before
favour-neuraco
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Bugfixes