fix: event queues and failed trace handling #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenJacobs61
added
the
version:minor
Contributor
|
Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking. |
1 similar comment
Contributor
|
Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking. |
StevenJacobs61
force-pushed
the
fix/improved-examples-flow
branch
from
deb670f to
81b9db3
Compare
muneebneura
reviewed
Feb 5, 2026
| return Path(env_override) | ||
|
|
||
| # Prefer a host-mounted workspace path if present (outside the container home). | ||
| host_default = Path("/home/steven/Documents/neuracore/state.db") |
Contributor
There was a problem hiding this comment.
remove the hardcoded host path
muneebneura
reviewed
Feb 5, 2026
| _START_TRACE_LOCK_MAX_RETRIES = 5 | ||
| _START_TRACE_LOCK_BASE_DELAY_S = 0.1 | ||
| _START_TRACE_LOCK_MAX_DELAY_S = 2.0 | ||
| _FAILED_TRACE_MAX_AGE_S = 60 * 60 * 4 # 4 hours |
Contributor
There was a problem hiding this comment.
Isn't the 4 hours too strict, even if they have valid data we remove it.
muneebneura
reviewed
Feb 5, 2026
Comment on lines
+34
to
37
| ensure_daemon_running() | ||
|
|
||
| ensure_daemon_running() | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Bugfixes