Skip to content

fix: impl path retrieving helper functions (#394)#398

Merged
StevenJacobs61 merged 1 commit intodevelopfrom
fix/ensure-channel-state-recommit
Feb 17, 2026
Merged

fix: impl path retrieving helper functions (#394)#398
StevenJacobs61 merged 1 commit intodevelopfrom
fix/ensure-channel-state-recommit

Conversation

@StevenJacobs61
Copy link
Contributor

@StevenJacobs61 StevenJacobs61 commented Feb 12, 2026

Features

  • Inited producer when start_recording each time.
  • Persisted recording context within robot instance
  • Cleaned up producer channels which had been stopped
  • Created sequence numbers for data chunks so that the stop recording didn't cause unprocessed valid chunks to be dropped.
  • Improved channel state.
  • Created thread-safe socket use (mark)

Bugfixes

  • Channels were closing and dropping data from one recording to the next
  • Stop recording caused unprocessed valiid (chunks sent before stop recording but just not processed yet) to be dropped

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2026

PR source branch is valid

  • Source: fix/ensure-channel-state-recommit
  • Target: develop

@StevenJacobs61 StevenJacobs61 added the version:minor non-breaking feature updates, new functions or endpoints label Feb 12, 2026
@github-actions
Copy link
Contributor

Consider updating changelogs/pending-changelog.md with a summary of this change for the release notes. This is optional and non-blocking.

@StevenJacobs61 StevenJacobs61 force-pushed the fix/ensure-channel-state-recommit branch 3 times, most recently from 88874d9 to 88b498e Compare February 16, 2026 22:37
Copy link
Contributor

@muneebneura muneebneura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StevenJacobs61 StevenJacobs61 force-pushed the fix/ensure-channel-state-recommit branch from 88b498e to 0e23530 Compare February 17, 2026 12:53
@StevenJacobs61 StevenJacobs61 force-pushed the fix/ensure-channel-state-recommit branch from 0e23530 to 5452111 Compare February 17, 2026 13:51
@StevenJacobs61 StevenJacobs61 merged commit e226189 into develop Feb 17, 2026
8 checks passed
@StevenJacobs61 StevenJacobs61 deleted the fix/ensure-channel-state-recommit branch February 17, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:minor non-breaking feature updates, new functions or endpoints

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants