Skip to content

Comments

fix: improved uploading pipeline#431

Open
muneebneura wants to merge 1 commit intodevelopfrom
fix/uploading-improvements
Open

fix: improved uploading pipeline#431
muneebneura wants to merge 1 commit intodevelopfrom
fix/uploading-improvements

Conversation

@muneebneura
Copy link
Contributor

@muneebneura muneebneura commented Feb 19, 2026

Fixes a few issues in the upload pipeline that were causing unnecessary slowness and incorrect behaviour when bandwidth limiting was enabled which is enabled by default in daemon.

Features

  • Global bandwidth limiter: Replaced per-uploader bandwidth throttling with a shared token-bucket. Previously each concurrent upload enforced the limit independently. The limiter is now shared across all uploaders so the aggregate rate is correctly capped.

Bugfixes

  • Removed upload semaphore — it was slowing down uploads by adding unnecessary contention between traces. Files within a trace are already sequential, so the semaphore only blocked other traces from uploading in parallel without any real benefit
  • Auth headers and org ID are now fetched in parallel instead of one after the other, reducing latency before each upload starts

Items

@muneebneura muneebneura added the version:patch non-breaking bug fixes; no input/output changes (except defaults) label Feb 19, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2026

PR source branch is valid

  • Source: fix/uploading-improvements
  • Target: develop

@muneebneura muneebneura force-pushed the fix/uploading-improvements branch from 11c2539 to 96046e4 Compare February 20, 2026 11:25
@muneebneura muneebneura force-pushed the fix/uploading-improvements branch from 96046e4 to a62c173 Compare February 20, 2026 11:46
Copy link
Contributor

@favour-neuraco favour-neuraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@muneebneura muneebneura force-pushed the fix/uploading-improvements branch from a62c173 to 550eec3 Compare February 20, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version:patch non-breaking bug fixes; no input/output changes (except defaults)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants