feat: move requirements.txt save folder in nc archive creation#432
Open
kwangneuraco wants to merge 4 commits intodevelopfrom
Open
feat: move requirements.txt save folder in nc archive creation#432kwangneuraco wants to merge 4 commits intodevelopfrom
kwangneuraco wants to merge 4 commits intodevelopfrom
Conversation
Contributor
|
✅ PR source branch is valid
|
Contributor
|
PR title and commit messages must follow conventional commit format: : . Valid prefixes: feat, fix, chore, docs, ci, test, refactor, style, perf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current algorithm folder, the requirements.txt is inside each algorithm to have specific version of some packages.
When creating nc archives it was saved outside the algorithm folder and is not actually properly installed. We didn't find this issue because algorithms except pi0 needs it. Now when i running pi0 server endpoint i have this issue