Temporary fix for MPI bug in Projection.get #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a rather subtle bug. The problem is that if gather is not 'all', on line 352 the method tries to address the array which is empty on nodes with rank != 0. Another solution would be to put that statement inside the preceding if-block and merge that if block with the enclosing one, so an empty 'values' is returned on nodes with rank != 0.
|
Many thanks for spotting this problem. Concerning the proposed solution, I would prefer not to change the public API where it can be avoided. In addition, using 'all' increases the network traffic, so will potentially slow down many simulations unnecessarily. Please could you create an Issue with a minimal script that illustrates the problem? |
|
That seems sensible. I'll implement the other proposed fix then? This may take a while as I'm currently busy with a deadline though (ISEK 2018). PS: thanks for all the good work on PyNN and Neo, finding it a delight to work with :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rather subtle bug. With MPI enabled it fails with error "File "projections.py", line 352, in get() : return values[0] : IndexError: list index out of range"
The problem is that if gather is not 'all', on line 352 the method tries to address the array which is empty on nodes with rank != 0. Another solution would be to put that statement inside the preceding if-block and merge that if block with the enclosing one, so an empty 'values' is returned on nodes with rank != 0.