Open
Conversation
ghostdeveloper404
requested changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Thanks for your contribution! @KyleighHarkless
I see that this PR contains two different sets of files:
Files that do not belong to Issue #14 (Typing Speed Tester):
- pySure/temp.py
- pySure/README.md
These are part of a temperature converter project, which belongs to a different issue.
Files that do belong to Issue #14:
- week1_projects/KyleighHarkless/README.md
- week1_projects/KyleighHarkless/Typing_speed_tester.py
Thanks for implementing the typing speed tester — however, the PR needs some adjustments before it can be merged:
✅ Required fixes
- Remove all Temperature Converter files from this PR
They are unrelated to this issue. - Move the typing speed tester into the correct folder structure:
your_name/typing_speed_tester/
main.py
README.md- Update accuracy calculation to match Issue #14’s requirement
The issue specifies character-based accuracy (not word-based). - Rename Typing_speed_tester.py to something consistent like main.py.
After making these updates, please push to the same PR.
I’ll review again — you’re very close!
Thanks again for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accuracy function isn't the best.