Skip to content

Comments

Typing speed tester#19

Open
KyleighHarkless wants to merge 13 commits intoNeuroByte-Society:mainfrom
KyleighHarkless:Typing-speed-tester
Open

Typing speed tester#19
KyleighHarkless wants to merge 13 commits intoNeuroByte-Society:mainfrom
KyleighHarkless:Typing-speed-tester

Conversation

@KyleighHarkless
Copy link

The accuracy function isn't the best.

Copy link
Contributor

@ghostdeveloper404 ghostdeveloper404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! @KyleighHarkless

I see that this PR contains two different sets of files:
Files that do not belong to Issue #14 (Typing Speed Tester):

  • pySure/temp.py
  • pySure/README.md
    These are part of a temperature converter project, which belongs to a different issue.

Files that do belong to Issue #14:

  • week1_projects/KyleighHarkless/README.md
  • week1_projects/KyleighHarkless/Typing_speed_tester.py
    Thanks for implementing the typing speed tester — however, the PR needs some adjustments before it can be merged:

✅ Required fixes

  1. Remove all Temperature Converter files from this PR
    They are unrelated to this issue.
  2. Move the typing speed tester into the correct folder structure:
your_name/typing_speed_tester/
    main.py
    README.md
  1. Update accuracy calculation to match Issue #14’s requirement
    The issue specifies character-based accuracy (not word-based).
  2. Rename Typing_speed_tester.py to something consistent like main.py.

After making these updates, please push to the same PR.
I’ll review again — you’re very close!

Thanks again for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants