fix(sbml-import): make TimeDerivative rhs have a per_time dimension
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise we end up with dimensionally incorrect values: ``` <TimeDerivative variable="time" value="1"/> ``` It'll now be: ``` <TimeDerivative variable="time" value="tscale * 1"/> ``` where `tscale` has dimensions `per_time`.
|
Great! Does the resultant file look like an izh cell? Test also the SBMLshowcase locally with this too. |
|
FYI this fails for me currently, should be fixed with this PR: https://github.com/OpenSourceBrain/SBMLShowcase/blob/master/regenerate.sh |
|
I'll go test it out with the SBML showcase next. Here's the generated izhikevich lems file: Runs OK from the looks of it:
|
yeh, seems to run fine with this PR: |
|
Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we end up with dimensionally incorrect values:
It'll now be:
where
tscalehas dimensionsper_time.