Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make TimeDerivative rhs have a per_time dimension #25

Merged
merged 3 commits into from
Jun 18, 2024
Merged

make TimeDerivative rhs have a per_time dimension #25

merged 3 commits into from
Jun 18, 2024

Commits on Jun 14, 2024

  1. fix(sbml-import): make TimeDerivative rhs have a per_time dimension 

    Otherwise we end up with dimensionally incorrect values:

```
<TimeDerivative variable="time" value="1"/>
```

It'll now be:

```
<TimeDerivative variable="time" value="tscale * 1"/>
```

where `tscale` has dimensions `per_time`.
    @sanjayankur31
    sanjayankur31 committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    b79aecf View commit details
    Browse the repository at this point in the history

  2. Merge pull request #24 from NeuroML/fix/sbml-derivative 

    fix(sbml-import): make TimeDerivative rhs have a `per_time` dimension
    @pgleeson
    pgleeson authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    44cfa92 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Adding volt as known sbml unit.

    @pgleeson
    pgleeson committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    cb2c52d View commit details
    Browse the repository at this point in the history