Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nwbview #149

Merged
merged 7 commits into from
Feb 10, 2024
Merged

add nwbview #149

merged 7 commits into from
Feb 10, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Feb 8, 2024

Hi folks :)

A follow-up PR after the SfN conference. Addressing #123.

I built it locally it renders fine. The html newlines are added for it to look nice. Here is the screenshot below.

Screenshot from 2024-02-08 13-35-19

@anilbey
Copy link
Contributor Author

anilbey commented Feb 8, 2024

@oruebel @rly could you review the PR? :)

I think the CI at the moment is failing for another reason.

@oruebel
Copy link
Contributor

oruebel commented Feb 8, 2024

I think the CI at the moment is failing for another reason.

CI is running now. I just had to approve it. I'm taking a look at the PR now.

@oruebel
Copy link
Contributor

oruebel commented Feb 8, 2024

Looks like some links are broken. I'll make a separate PR to fix links and then this should be good to merge.

@oruebel
Copy link
Contributor

oruebel commented Feb 8, 2024

@stephprince could you take a look at the broken link issue? I tried to add the configuration for the linkchecker to ignore the link but for some reason it doesn't seem to work.

docs/source/conf.py Outdated Show resolved Hide resolved
@oruebel
Copy link
Contributor

oruebel commented Feb 8, 2024

Looks like the failing linkcheck is now a seperate issue with a timeout form biorxiv. It looks like https://www.biorxiv.org/ may be unavailable for some reason right now. I think we can probably just rerun the linkchecker again later and then merge.

@anilbey
Copy link
Contributor Author

anilbey commented Feb 9, 2024

Great, thanks for your effort

@oruebel oruebel merged commit fdba5a1 into NeurodataWithoutBorders:main Feb 10, 2024
2 checks passed
@oruebel
Copy link
Contributor

oruebel commented Feb 10, 2024

Thanks @anilbey ! All tests passed now and I have merged the PR.

@oruebel oruebel mentioned this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants