Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough이 변경사항은 Redis 기반 캐시 시스템을 도입 및 확장하고, 서비스 계층에 Spring Cache 어노테이션을 추가하여 캐시 일관성 및 성능을 개선합니다. 주요 서비스 메서드에 캐시 저장, 캐시 무효화 로직을 적용하며, Redis 캐시 매니저 및 전용 캐시 Redis 설정, AOP 기반 실행시간 로깅, 컨트롤러 및 서비스 구조 리팩토링이 포함됩니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Controller
participant HistoryService
participant RedisCache
participant Repository
Client->>Controller: getGroupedNewsHistory(page, size, auth)
Controller->>HistoryService: getGroupedNewsHistory(page, size, auth)
alt Cache Hit
HistoryService->>RedisCache: Get groupedNewsHistory
RedisCache-->>HistoryService: Return cached result
HistoryService-->>Controller: Return cached PageResponse
else Cache Miss
HistoryService->>Repository: findAllByUserId
Repository-->>HistoryService: List<History>
HistoryService->>Repository: findAllByHistoryIdIn
Repository-->>HistoryService: List<FeedBack>
HistoryService->>RedisCache: Put groupedNewsHistory
HistoryService-->>Controller: Return new PageResponse
end
Controller-->>Client: PageResponse<GroupedNewsHistoryResponse>
sequenceDiagram
participant Service
participant RedisCache
Service->>RedisCache: @CacheEvict("groupedNewsHistory") on saveHistory/sendSingleKakaoMessage/feedback
RedisCache-->>Service: Invalidate all groupedNewsHistory cache
Estimated code review effort🎯 4 (Complex) | ⏱️ ~40 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (11)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
캐싱 시스템 적용
Summary by CodeRabbit
신규 기능
버그 수정
리팩터링/구조 개선
환경설정