-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: local build on macOS or other platform #41
Conversation
Reviewer's Guide by SourceryThis pull request enables local builds on macOS, adds support for Arch Linux, and updates build commands. It also modifies the Android SDK version and removes an unnecessary build step. Flow diagram for updated build processflowchart TB
start[Start Build] --> checkOS{Check OS}
checkOS -->|macOS| installXcode[Install Xcode Tools]
checkOS -->|Linux| skipXcode[Skip Xcode Install]
installXcode --> installTools[Install Required Tools]
skipXcode --> installTools
installTools --> installSDK[Install Android SDK Components]
installSDK --> buildGradle[Build with Gradle]
buildGradle --> assembleBuild[assemble Debug/Release]
assembleBuild --> done[Done]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ruattd - I've reviewed your changes - here's some feedback:
Overall Comments:
- Please explain why the debug signing configuration was commented out. If this is necessary for macOS builds, it should be documented.
- The PR description mentions uncertainty about CI impact. Please verify that these changes don't break CI builds before merging.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Now macOS can build the app locally, but I'm not sure whether the changes will affect CI build. Most likely not.
By the way, it seems
./run libs native
is not necessary forassembleDebug
now.Summary by Sourcery
Add support for building the app on macOS.
New Features:
Enhancements:
Build: