Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local build on macOS or other platform #41

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

ruattd
Copy link
Contributor

@ruattd ruattd commented Jan 12, 2025

Now macOS can build the app locally, but I'm not sure whether the changes will affect CI build. Most likely not.
By the way, it seems ./run libs native is not necessary for assembleDebug now.

Summary by Sourcery

Add support for building the app on macOS.

New Features:

  • Enable local builds on macOS.

Enhancements:

  • Simplify the Gradle build command.

Build:

  • Update build instructions to include macOS and Arch Linux.

Copy link

sourcery-ai bot commented Jan 12, 2025

Reviewer's Guide by Sourcery

This pull request enables local builds on macOS, adds support for Arch Linux, and updates build commands. It also modifies the Android SDK version and removes an unnecessary build step.

Flow diagram for updated build process

flowchart TB
    start[Start Build] --> checkOS{Check OS}
    checkOS -->|macOS| installXcode[Install Xcode Tools]
    checkOS -->|Linux| skipXcode[Skip Xcode Install]
    installXcode --> installTools[Install Required Tools]
    skipXcode --> installTools
    installTools --> installSDK[Install Android SDK Components]
    installSDK --> buildGradle[Build with Gradle]
    buildGradle --> assembleBuild[assemble Debug/Release]
    assembleBuild --> done[Done]
Loading

File-Level Changes

Change Details Files
Added macOS and Arch Linux support for local builds
  • Added instructions for installing necessary tools on macOS and Arch Linux.
  • Updated the list of supported operating systems to include macOS and Arch Linux.
README.md
Updated Android SDK version and build commands
  • Updated the required Android SDK version.
  • Modified Gradle build command.
  • Removed unnecessary ./run libs native step for assembleDebug command.
README.md
TMessagesProj/build.gradle
Fixed build script compatibility issue
  • Updated build scripts to use the correct LLVM prefix based on the build platform.
TMessagesProj/jni/build_dav1d_clang.sh
TMessagesProj/jni/build_ffmpeg_clang.sh
TMessagesProj/jni/build_libvpx_clang.sh
Fixed file copy command in patch script
  • Corrected the file copy command to handle filenames with spaces correctly.
TMessagesProj/jni/patch_ffmpeg.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ruattd - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please explain why the debug signing configuration was commented out. If this is necessary for macOS builds, it should be documented.
  • The PR description mentions uncertainty about CI impact. Please verify that these changes don't break CI builds before merging.
Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

README.md Show resolved Hide resolved
@ruattd ruattd changed the title Fix local build on macOS or other platform fix: local build on macOS or other platform Jan 12, 2025
@omg-xtao omg-xtao merged commit 77f0a76 into NextAlone:dev Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants