Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable sensitive content filtering #43

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

risin42
Copy link
Contributor

@risin42 risin42 commented Jan 29, 2025

Fixes a connection issue (stuck on updating/loading) caused by an upstream TLRPC refactor.

Steps to reproduce:

  1. Go to Experimental settings. Notice the "disable sensitive content filtering" option is disabled.
  2. Go back to the dialog list and tap to open any group or profile. You'll see it gets stuck on updating or loading.

Summary by Sourcery

Bug Fixes:

  • Fix a connection issue that caused the app to get stuck on updating or loading when opening a group or profile.

Copy link

sourcery-ai bot commented Jan 29, 2025

Reviewer's Guide by Sourcery

This pull request fixes a connection issue where the app gets stuck on updating/loading when opening a group or profile. The issue was caused by a refactor in the upstream TLRPC. The fix involves updating the code to use the new TL_account classes instead of the old TLRPC classes.

Sequence diagram for sensitive content settings update

sequenceDiagram
    participant User as User
    participant UI as NekoExperimentalSettingsActivity
    participant Server as Content Settings Server

    User->>UI: Toggle sensitive content filter
    UI->>Server: TL_account.setContentSettings(sensitive_enabled)
    Note over UI: Show progress dialog
    Server-->>UI: Response
    UI->>UI: Update UI state
    UI->>User: Show updated settings
Loading

Class diagram showing content settings refactor

classDiagram
    class TL_account {
        +setContentSettings
        +getContentSettings
        +contentSettings
    }
    class contentSettings {
        +boolean sensitive_enabled
        +boolean sensitive_can_change
    }
    note for TL_account "Refactored from TLRPC namespace"
    TL_account -- contentSettings
Loading

File-Level Changes

Change Details Files
Updated the code to use the new TL_account classes instead of the old TLRPC classes.
  • Replaced TLRPC.TL_account_setContentSettings with TL_account.setContentSettings.
  • Replaced TLRPC.TL_account_getContentSettings with TL_account.getContentSettings.
  • Replaced TLRPC.TL_account_contentSettings with TL_account.contentSettings.
TMessagesProj/src/main/java/tw/nekomimi/nekogram/settings/NekoExperimentalSettingsActivity.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @risin42 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@@ -502,10 +503,10 @@ public ArrayList<ThemeDescription> getThemeDescriptions() {
}

private void checkSensitive() {
TLRPC.TL_account_getContentSettings req = new TLRPC.TL_account_getContentSettings();
TL_account.getContentSettings req = new TL_account.getContentSettings();
getConnectionsManager().sendRequest(req, (response, error) -> AndroidUtilities.runOnUIThread(() -> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Add error handling for the case where the request fails

Currently, if the request fails (error != null), the UI state won't be updated. This could lead to inconsistent state. Consider handling the error case appropriately.

Copy link
Owner

@NextAlone NextAlone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @omg-xtao

.github/workflows/pr.yml Show resolved Hide resolved
@omg-xtao omg-xtao merged commit 68cf709 into NextAlone:dev Jan 29, 2025
5 checks passed
@omg-xtao
Copy link
Collaborator

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants