-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added back basic Bannerlord support #2180
Conversation
Thanks for setting this up @Aragas. We have a few bits to finish off before we properly dive into Bannerlord support so don't worry if this takes a while to get reviewed :) |
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/MountAndBlade2BannerlordSettings.cs
Show resolved
Hide resolved
...ames/NexusMods.Games.MountAndBlade2Bannerlord/MountAndBlade2BannerlordLoadoutSynchronizer.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/Utils/GamePathProvier.cs
Show resolved
Hide resolved
I went through around half of this, will look at the other half this morning. CC. @Aragas I also started a draft of the info documentation page for the game (to familiarise myself with Bannerlord). I did some digging around for a few hours. I think it's around ~80% of the way there; just need some extra minor details mentioned such as where the load order and enabled mods are saved, etc. added. Look through the text below and make any improvements/changes to it as needed. General Info
Stores and Ids
Useful LinksEngine and Mod SupportBannerlord uses a native engine with self-hosted .NET 6 for Steam/GOG/Epic. Bannerlord has a modding extension BLSE It's required to run mods on Xbox and is optional for Steam/GOG/Epic. Installing Mods (Outside of NMA)AutomaticTypically installs immediately via Steam Client ManualMod TypesSince it's not a standard mod. BLSEBLSE needs to be placed beside the main game binary:
Outside of that, we will want to launch BLSE rather than the regular game binary if BLSE is installed. Typical Mod Structure (Module)
The only needed file is Note that the Example
|
...ames/NexusMods.Games.MountAndBlade2Bannerlord/MountAndBlade2BannerlordLoadoutSynchronizer.cs
Outdated
Show resolved
Hide resolved
...ames/NexusMods.Games.MountAndBlade2Bannerlord/MountAndBlade2BannerlordLoadoutSynchronizer.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/LauncherManager/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/LauncherManager/FileSystemProvider.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/LauncherManager/LauncherManagerNexusMods.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/Utils/ModuleContext.cs
Outdated
Show resolved
Hide resolved
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/LauncherManager/NotificationProvider.cs
Show resolved
Hide resolved
src/Games/NexusMods.Games.MountAndBlade2Bannerlord/LauncherManager/LauncherManagerFactory.cs
Show resolved
Hide resolved
@Sewer56 |
It should be generally safe to use |
Save files contain the mods and the versions that were used. We produce a warning in both BLSE and Vortex when the version mismatches (should be an error if we downgraded, but I haven't done that yet) |
Oh that's whack, so they have an entire untrimmed .NET 6.0.12 runtime present in the game files but that goes entirely unused. |
@Aragas as for the big blob of text. Just make any edits you deem necessary and throw it in the markdown file (alongside other games in |
The way we emit warnings in the App is through the 'Health Check' (Diagnostics) view. And if it's a module that's required by another mod: Although there isn't any UX around this currently, the plans are to stop the user if there's any diagnostic which emits a |
It's like this for a long time, we also had some jokes regarding this. The game developers were in the process of migrating .NET FX 472 libraries into .NET Standard2.0, but I haven;t checked for a whle if they finished or not |
7b6cce8
to
6185f98
Compare
This PR conflicts with |
…s for future integration
This PR doesn't conflict with |
LauncherManager now guarantees that the Index property is set
No description provided.