feat(access-list): add optional note field to access list clients#5333
Open
TheMazeIsAmazing wants to merge 4 commits intoNginxProxyManager:developfrom
Open
feat(access-list): add optional note field to access list clients#5333TheMazeIsAmazing wants to merge 4 commits intoNginxProxyManager:developfrom
TheMazeIsAmazing wants to merge 4 commits intoNginxProxyManager:developfrom
Conversation
… widen modal - Add optional note property to access list clients in backend model and schema - Extend OpenAPI schemas (common + access-list endpoints) to support note - Created necessary migration to add the note row to access_list_client table - Persist note in access_list_client inserts/updates - Render note in nginx config as inline comment for access rules (when present) - Extend frontend AccessListClient model with optional note - Add note input field to Access List modal (Rules tab) - Only include note in payload when non-empty - Add i18n placeholder for note field - Increase Access List modal width for improved usability
|
Docker Image for build 5 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
Author
|
Update 27 feb. 2026: Just added localizations for all available languages in the Thanks in advance for your feedback and time 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on my earlier Feature Request, nr. 5277, I thought I might take a jab at it myself.
This PR introduces an optional “note” field for access list client rules to improve clarity when managing multiple IP entries. It allows users to annotate each rule (e.g. “Home”, “Office”, “VPN”) without affecting nginx behaviour.
Backend changes:
noteproperty to access list client schema.note.notefully optional and backwards-compatible with existing data.Frontend changes:
AccessListClienttype withnote?: string.notein API payload only when non-empty.If something is broken, or needs to be fixed, let me know. Thanks for your time!