ДЗ № 6.1 Сортированный список, Шестаков Николай#11
Open
NicholayShestakov wants to merge 4 commits intomainfrom
Open
ДЗ № 6.1 Сортированный список, Шестаков Николай#11NicholayShestakov wants to merge 4 commits intomainfrom
NicholayShestakov wants to merge 4 commits intomainfrom
Conversation
WoWaster
requested changes
Dec 12, 2025
Collaborator
WoWaster
left a comment
WoWaster
left a comment
There was a problem hiding this comment.
Не считая странной обработки ошибок, очень даже круто
| List* createList(); | ||
|
|
||
| // Deletes the sorted list and frees memory it used. | ||
| // Takes pointer on the sorted list. |
Collaborator
There was a problem hiding this comment.
Про Ваш английский писал в каком-то из соседних PR'ов :)
| free(list); | ||
| } | ||
|
|
||
| void appendValue(List* list, int value) |
Collaborator
There was a problem hiding this comment.
Вообще append обычно объединяет списки, но вообще пойдёт
Comment on lines
+72
to
+74
| if (list->head == NULL) { | ||
| printf("The list is empty. \n"); | ||
| return; |
Collaborator
There was a problem hiding this comment.
Очень плохая идея. Возвращайте bool или используйте errorCode/outValue или запрещайте вызов функции на пустом списке
Comment on lines
+82
to
+85
| if (list->tail->value < value) { | ||
| printf("The list not contains this value. \n"); | ||
| return; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add