Skip to content

Commit

Permalink
types: fix _Condition typing used with join()
Browse files Browse the repository at this point in the history
  • Loading branch information
NickCrews committed Jan 22, 2025
1 parent 41fd8d5 commit 5feabbc
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mismo/block/_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
Literal[True, False],
tuple[_ColumnReferenceLike, _ColumnReferenceLike],
]
_Condition = Union[
_IntoCondition = Union[
_ConditionAtom,
Callable[[ir.Table, ir.Table], _ConditionAtom],
]
Expand All @@ -29,7 +29,7 @@
def join(
left: ir.Table,
right: ir.Table,
*conditions: _Condition,
*conditions: _IntoCondition,
on_slow: Literal["error", "warn", "ignore"] = "error",
task: Literal["dedupe", "link"] | None = None,
**kwargs,
Expand Down Expand Up @@ -189,7 +189,7 @@ class _Condition(NamedTuple):

# TODO: This is a bit of a hot mess. Can we simplify this?
def _resolve_conditions(
left: ir.Table, right: ir.Table, raw: tuple[_Condition], **kwargs
left: ir.Table, right: ir.Table, raw: tuple[_IntoCondition], **kwargs
) -> ir.Table | tuple[ir.Table, ir.Table, ir.BooleanValue]:
conditions = [
_resolve_condition(left, right, condition, **kwargs) for condition in raw
Expand Down

0 comments on commit 5feabbc

Please sign in to comment.