Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying files #86

Merged
merged 10 commits into from
Jan 17, 2024
Merged

Modifying files #86

merged 10 commits into from
Jan 17, 2024

Conversation

Edgar-Degas
Copy link
Contributor

No description provided.

@Edgar-Degas Edgar-Degas changed the title Modifing files Modifying files Jan 8, 2024
Copy link
Owner

@NickSwainston NickSwainston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your eagle-eyed corrections! There is only one change that I disagree with. Once you revert the change or convince me that you are correct, I will approve my review and merge in your branch

@@ -1,7 +1,7 @@
{
"J0023+0923": {
"Frequency MHz": [
1284
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the text: "All observations included in this paper were performed with
the MeerKAT L-band receiver (856–1 712 MHz) with the Pulsar
Timing User Supplied Equipement (PTUSE) back-end that uses
coherent dedispersion."
From this, the centre frequency is 1284 MHz and the 1400 MHz used on the tables is just an approximation to common values. If you agree with me, please change these values back to 1284.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I changed it back. Thank you for pointing that out.

@NickSwainston
Copy link
Owner

@NickSwainston NickSwainston merged commit 43b8653 into NickSwainston:main Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants