Link and reference convert fix #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cplee1
reviewed
Mar 19, 2024
tests/test_catalogue.py
Outdated
| query = psrqpy.QueryATNF(version=ATNF_VER).pandas | ||
| flux_queries = [] | ||
| for table_param in query.keys(): | ||
| if re.match("S\d*\d$", table_param) or re.match("S\d*G$", table_param): |
There was a problem hiding this comment.
Pytest returns a warning for this line: "invalid escape sequence '\d'". Is this okay?
There was a problem hiding this comment.
I've added an r in front of those strings to declare that it is a re pattern, which removed the warning.
…eclare it is a re patern
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an incorrect link mentioned in issue #89
Fixed the ANTF reference formatting and made a test to cover it so instead of this reference:
We get this correct one: