Merge pull request #763 from NickvisionApps/more-logs

Print to stderr when there is an exception
NickvisionApps · Dec 26, 2023 · f0f48eb · f0f48eb
2 parents 0b68871 + 4d3c096
commit f0f48eb
Show file tree

Hide file tree

Showing 13 changed files with 70 additions and 32 deletions.
diff --git a/NickvisionMoney.GNOME/Program.cs b/NickvisionMoney.GNOME/Program.cs
@@ -45,6 +45,7 @@ public Program(string[] args)
             @"* Fixed an issue where the generated ids of new transactions were incorrect.
               * Fixed an issue that caused sort to behave inconsistently.
               * Fixed calendar not showing marks for transactions after pressing the ""Today"" button.
+              * Added more logging to help debug issues.
               * Updated and added translations (Thanks to everyone on Weblate)!";
         _application.OnActivate += OnActivate;
         if (File.Exists(Path.GetFullPath(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)) + "/org.nickvision.money.gresource"))
@@ -86,8 +87,7 @@ public int Run(string[] args)
         }
         catch (Exception ex)
         {
-            Console.WriteLine(ex.Message);
-            Console.WriteLine($"\n\n{ex.StackTrace}");
+            Console.Error.WriteLine(ex);
             return -1;
         }
     }

diff --git a/NickvisionMoney.GNOME/Views/AccountView.cs b/NickvisionMoney.GNOME/Views/AccountView.cs
@@ -776,7 +776,10 @@ private async void ImportFromFile(Gio.SimpleAction sender, EventArgs e)
             _viewStack.SetVisibleChildName(_viewStack.GetVisibleChildName() == "spinner" ? oldPage : _viewStack.GetVisibleChildName());
             _paneScroll.SetSensitive(true);
         }
-        catch { }
+        catch (Exception ex)
+        {
+            Console.Error.WriteLine(ex);
+        }
     }
 
     /// <summary>
@@ -803,7 +806,10 @@ private async Task ExportToCSVAsync(ExportMode exportMode)
             }
             _controller.ExportToCSV(path ?? "", exportMode);
         }
-        catch { }
+        catch (Exception e)
+        {
+            Console.Error.WriteLine(e);
+        }
     }
 
     /// <summary>
@@ -853,7 +859,10 @@ private async Task ExportToPDFAsync(ExportMode exportMode)
             };
             dialog.Present();
         }
-        catch { }
+        catch (Exception e)
+        {
+            Console.Error.WriteLine(e);
+        }
     }
 
     /// <summary>

diff --git a/NickvisionMoney.GNOME/Views/MainWindow.cs b/NickvisionMoney.GNOME/Views/MainWindow.cs
@@ -185,7 +185,10 @@ private void NotificationSent(object? sender, NotificationSentEventArgs e)
                 {
                     await fileLauncher.LaunchAsync(this);
                 }
-                catch { }
+                catch (Exception exception)
+                {
+                    Console.Error.WriteLine(exception);
+                }
             };
         }
         _toastOverlay.AddToast(toast);
@@ -309,7 +312,10 @@ private async void OnOpenAccount(Gio.SimpleAction sender, EventArgs e)
             var file = await openFileDialog.OpenAsync(this);
             await _controller.AddAccountAsync(file.GetPath());
         }
-        catch { }
+        catch (Exception exception)
+        {
+            Console.Error.WriteLine(exception);
+        }
     }
 
     /// <summary>

diff --git a/NickvisionMoney.GNOME/Views/NewAccountDialog.cs b/NickvisionMoney.GNOME/Views/NewAccountDialog.cs
@@ -276,7 +276,10 @@ private async void SelectFolder(object? sender, EventArgs e)
             _folderRow.SetText(Path.GetFileName(_controller.Folder));
             ValidateName();
         }
-        catch { }
+        catch (Exception exception)
+        {
+            Console.Error.WriteLine(exception);
+        }
     }
 
     /// <summary>
@@ -469,7 +472,10 @@ private async void SelectImportFile(object? sender, EventArgs e)
             _controller.ImportFile = file.GetPath();
             _importRow.SetText(_controller.ImportFile);
         }
-        catch { }
+        catch (Exception exception)
+        {
+            Console.Error.WriteLine(exception);
+        }
     }
 
     /// <summary>

diff --git a/NickvisionMoney.GNOME/Views/PreferencesDialog.cs b/NickvisionMoney.GNOME/Views/PreferencesDialog.cs
@@ -166,7 +166,10 @@ private async void SelectBackupFolder(Gtk.Button sender, EventArgs e)
                 _csvBackupRow.SetText(path);
             }
         }
-        catch { }
+        catch (Exception exception)
+        {
+            Console.Error.WriteLine(exception);
+        }
     }
 
     /// <summary>

diff --git a/NickvisionMoney.GNOME/Views/TransactionDialog.cs b/NickvisionMoney.GNOME/Views/TransactionDialog.cs
@@ -708,6 +708,9 @@ private async void OnUploadReceipt(Gtk.Button sender, EventArgs e)
             }
             Validate();
         }
-        catch { }
+        catch (Exception ex)
+        {
+            Console.Error.WriteLine(ex);
+        }
     }
 }
diff --git a/NickvisionMoney.GNOME/Views/TransferDialog.cs b/NickvisionMoney.GNOME/Views/TransferDialog.cs
@@ -239,7 +239,10 @@ private async void OnSelectAccount(Gtk.Button sender, EventArgs e)
             _destinationCurrencyRow.SetText("");
             Validate();
         }
-        catch { }
+        catch (Exception exception)
+        {
+            Console.Error.WriteLine(exception);
+        }
     }
 
     /// <summary>

diff --git a/NickvisionMoney.Shared/Controllers/AccountViewController.cs b/NickvisionMoney.Shared/Controllers/AccountViewController.cs
@@ -931,8 +931,9 @@ public async Task ImportFromFileAsync(string path)
         {
             res = await _account.ImportFromFileAsync(path, TransactionDefaultColor, GroupDefaultColor);
         }
-        catch
+        catch (Exception e)
         {
+            Console.Error.WriteLine(e);
             NotificationSent?.Invoke(this, new NotificationSentEventArgs(_("Unable to import information from the file. Please ensure that the app has permissions to access the file and try again."), NotificationSeverity.Error));
             return;
         }

diff --git a/NickvisionMoney.Shared/Controllers/MainWindowController.cs b/NickvisionMoney.Shared/Controllers/MainWindowController.cs
@@ -287,8 +287,9 @@ public async Task<bool> NewAccountAsync(NewAccountDialogController controller)
         {
             accountViewController.Login(null);
         }
-        catch
+        catch (Exception e)
         {
+            Console.Error.WriteLine(e);
             NotificationSent?.Invoke(this, new NotificationSentEventArgs(_("Unable to open the account. Please ensure that the app has permissions to access the file and try again."), NotificationSeverity.Error));
             return false;
         }
@@ -340,8 +341,9 @@ public async Task<bool> AddAccountAsync(string path, bool showOpenedNotification
                     return false;
                 }
             }
-            catch
+            catch (Exception e)
             {
+                Console.Error.WriteLine(e);
                 NotificationSent?.Invoke(this, new NotificationSentEventArgs(_("Unable to open the account. Please ensure that the app has permissions to access the file and try again."), NotificationSeverity.Error));
                 return false;
             }

diff --git a/NickvisionMoney.Shared/Linux/org.nickvision.money.metainfo.xml.in b/NickvisionMoney.Shared/Linux/org.nickvision.money.metainfo.xml.in
@@ -52,6 +52,7 @@
         <p>- Fixed an issue where the generated ids of new transactions were incorrect.</p>
         <p>- Fixed an issue that caused sort to behave inconsistently.</p>
         <p>- Fixed calendar not showing marks for transactions after pressing the "Today" button.</p>
+        <p>- Added more logging to help debug issues. </p>
         <p>- Updated translations (Thanks to everyone on Weblate)!</p>
       </description>
     </release>

diff --git a/NickvisionMoney.Shared/Models/Account.cs b/NickvisionMoney.Shared/Models/Account.cs
@@ -324,8 +324,9 @@ public bool Login(string? password)
                 _database.Open();
                 _loggedIn = true;
             }
-            catch
+            catch (Exception e)
             {
+                Console.Error.WriteLine(e);
                 _database.Close();
                 _database.Dispose();
                 _database = null;
@@ -1207,6 +1208,7 @@ public async Task<ImportResult> ImportFromFileAsync(string path, string defaultT
     {
         if (!System.IO.Path.Exists(path))
         {
+            Console.Error.WriteLine($"File not found: {path}");
             return ImportResult.Empty;
         }
         var extension = System.IO.Path.GetExtension(path).ToLower();
@@ -1222,6 +1224,7 @@ public async Task<ImportResult> ImportFromFileAsync(string path, string defaultT
         {
             return await ImportFromQIFAsync(path, defaultTransactionRGBA, defaultGroupRGBA);
         }
+        Console.Error.WriteLine($"Unsupported file extension: {extension}");
         return ImportResult.Empty;
     }
 
@@ -1239,8 +1242,9 @@ private async Task<ImportResult> ImportFromCSVAsync(string path, string defaultT
         {
             lines = File.ReadAllLines(path);
         }
-        catch
+        catch (Exception e)
         {
+            Console.Error.WriteLine(e);
             return ImportResult.Empty;
         }
         var importResult = new ImportResult();
@@ -1427,8 +1431,9 @@ private async Task<ImportResult> ImportFromOFXAsync(string path, string defaultT
         {
             ofx = new OFXDocumentParser().Import(ofxString);
         }
-        catch
+        catch (Exception e)
         {
+            Console.Error.WriteLine(e);
             return ImportResult.Empty;
         }
         //Transactions
@@ -1471,8 +1476,9 @@ private async Task<ImportResult> ImportFromQIFAsync(string path, string defaultT
             qif = QifDocument.Load(File.OpenRead(path));
             Thread.CurrentThread.CurrentCulture = oldCulture;
         }
-        catch
+        catch (Exception e)
         {
+            Console.Error.WriteLine(e);
             return ImportResult.Empty;
         }
         var importResult = new ImportResult();
@@ -1558,8 +1564,9 @@ public bool ExportToCSV(string path, ExportMode exportMode, List<uint> filteredI
             File.WriteAllText(path, result);
             return true;
         }
-        catch
+        catch (Exception e)
         {
+            Console.Error.WriteLine(e);
             return false;
         }
     }
@@ -1851,7 +1858,7 @@ public bool ExportToPDF(string path, ExportMode exportMode, List<uint> filteredI
         }
         catch (Exception e)
         {
-            Console.WriteLine(e);
+            Console.Error.WriteLine(e);
             return false;
         }
         return true;

diff --git a/NickvisionMoney.Shared/Models/AccountMetadata.cs b/NickvisionMoney.Shared/Models/AccountMetadata.cs
@@ -225,8 +225,9 @@ internal static void UpdateMetadataDatabaseTable(SqliteConnection database)
         {
             database.Open();
         }
-        catch
+        catch (Exception e)
         {
+            Console.Error.WriteLine(e);
             database.Close();
             return null;
         }

diff --git a/NickvisionMoney.Shared/Models/CurrencyConversionService.cs b/NickvisionMoney.Shared/Models/CurrencyConversionService.cs
@@ -16,7 +16,7 @@ public class CurrencyConversion
     /// <summary>
     /// The currency code of the source amount
     /// </summary>
-    public string SourceCurrnecy { get; init; }
+    public string SourceCurrency { get; init; }
     /// <summary>
     /// The source amount to convert
     /// </summary>
@@ -44,7 +44,7 @@ public class CurrencyConversion
     /// <param name="conversionRate">The rate of conversion from the source currency to the result currency</param>
     public CurrencyConversion(string sourceCurrency, decimal sourceAmount, string resultCurrency, decimal conversionRate)
     {
-        SourceCurrnecy = sourceCurrency;
+        SourceCurrency = sourceCurrency;
         SourceAmount = sourceAmount;
         ResultCurrency = resultCurrency;
         ConversionRate = conversionRate;
@@ -114,8 +114,7 @@ static CurrencyConversionService()
             catch (Exception e)
             {
                 // Couldn't get the cached rates
-                Console.WriteLine(e.Message);
-                Console.WriteLine(e.StackTrace);
+                Console.Error.WriteLine(e);
                 needsUpdate = true;
                 json?.Dispose();
             }
@@ -135,8 +134,7 @@ static CurrencyConversionService()
             }
             catch (Exception e)
             {
-                Console.WriteLine(e.Message);
-                Console.WriteLine(e.StackTrace);
+                Console.Error.WriteLine(e);
                 json?.Dispose();
                 return null;
             }
@@ -155,16 +153,14 @@ static CurrencyConversionService()
                     }
                     catch (Exception e)
                     {
-                        Console.WriteLine(e.Message);
-                        Console.WriteLine(e.StackTrace);
+                        Console.Error.WriteLine(e);
                     }
                 }
                 return rates;
             }
             catch (Exception e)
             {
-                Console.WriteLine(e.Message);
-                Console.WriteLine(e.StackTrace);
+                Console.Error.WriteLine(e);
                 return null;
             }
             finally