Reduce false positive

Avoid extraction fake translation of empty string
NicolasGrosjean · Apr 16, 2021 · 030258f · 030258f
1 parent 01b8220
commit 030258f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/extract_existing_translation.py b/src/extract_existing_translation.py
@@ -50,7 +50,7 @@ def extract_translation_from_yml_file(source_loc_file, dest_loc_file, extracted_
     source_texts, _ = file_to_keys_and_values(source_loc_file)
     dest_texts, _ = file_to_keys_and_values(dest_loc_file)
     for source_key in source_texts.keys():
-        if source_key in dest_texts.keys():
+        if source_key in dest_texts.keys() and source_texts[source_key]['value'] != '':
             extracted_translation[source_texts[source_key]['value']] = dest_texts[source_key]['value']