Skip to content

fixed kNN for kNNBasic on issue #131#138

Closed
ODemidenko wants to merge 3 commits intoNicolasHug:masterfrom
ODemidenko:kNN-top
Closed

fixed kNN for kNNBasic on issue #131#138
ODemidenko wants to merge 3 commits intoNicolasHug:masterfrom
ODemidenko:kNN-top

Conversation

@ODemidenko
Copy link
Copy Markdown
Contributor

currently I introduced all the changes only to one kNN algo. If you ok with this implementation - I immediately proceed with the others

  • Move "Compute similarity" from AlgoBase into SymmetricAlg (as it belongs to kNN only)
  • implement common logic for fixed kNN
  • inject new logic into kNNBasic, as optional behaviour
  • test new behaviour vs teacher examples from Coursera course
  • inject new logic into kNNWithMeans, as optional behaviour
  • inject new logic into kNNBaseline, as optional behaviour

@ODemidenko ODemidenko closed this by deleting the head repository Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant