Skip to content

Fix spawner filter GUI exploit allowing navigation after spawner destruction #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ptthanh02 merged 2 commits into from
Sep 13, 2025
Merged

Fix spawner filter GUI exploit allowing navigation after spawner destruction #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da3a69c
Initial plan
Copilot Sep 13, 2025
d4f5310
Implement ghost spawner validation in FilterConfigUI to prevent navig…
Copilot Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions core/src/main/java/github/nighter/smartspawner/SmartSpawner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,10 @@ public SpawnerStorageUI getSpawnerStorageUI() {
return spawnerStorageUI;
}

public SpawnerManager getSpawnerManager() {
return spawnerManager;
}

public SpawnerRangeChecker getRangeChecker() {
return rangeChecker;
}
Expand Down
24 changes: 24 additions & 0 deletions .../src/main/java/github/nighter/smartspawner/spawner/gui/storage/filter/FilterConfigUI.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ public void onPlayerQuit(PlayerQuitEvent event) {
* Opens the filter configuration GUI for a player and spawner
*/
public void openFilterConfigGUI(Player player, SpawnerData spawner) {
// Validate that the spawner still exists before opening the GUI
if (plugin.getSpawnerManager().isGhostSpawner(spawner)) {
// Spawner no longer exists, do not open the GUI
player.playSound(player.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 0.8f, 0.5f);
return;
}

// Create a new inventory with title from language manager
String title = languageManager.getGuiTitle("gui_title_filter_config");
Inventory filterInventory = Bukkit.createInventory(
Expand Down Expand Up @@ -222,6 +229,15 @@ public void onFilterInventoryClick(InventoryClickEvent event) {
}

SpawnerData spawner = holder.getSpawnerData();

// Validate that the spawner still exists before processing any actions
if (plugin.getSpawnerManager().isGhostSpawner(spawner)) {
// Spawner no longer exists, close the inventory
player.playSound(player.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 0.8f, 0.5f);
player.closeInventory();
return;
}

int slot = event.getRawSlot();

// Handle divider clicks (return to storage)
Expand All @@ -248,6 +264,14 @@ public void onFilterInventoryClick(InventoryClickEvent event) {
* Returns to the spawner storage UI
*/
private void returnToStorage(Player player, SpawnerData spawner) {
// Validate that the spawner still exists before allowing navigation
if (plugin.getSpawnerManager().isGhostSpawner(spawner)) {
// Spawner no longer exists, close the inventory and prevent navigation
player.playSound(player.getLocation(), Sound.BLOCK_NOTE_BLOCK_BASS, 0.8f, 0.5f);
player.closeInventory();
return;
}

// Return to storage menu
player.playSound(player.getLocation(), Sound.UI_BUTTON_CLICK, 0.8f, 1.0f);
player.closeInventory();
Expand Down