This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Implemented Secure File API #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pierre Poissinger <pierre.poissinger@nike.com>
|
Did you user acceptance test this, AKA try it out EDIT: this is not the CLI, but I would still like assurance that there was user acceptance testing and someone verified that it actually works against a real instance of Cerberus. |
|
Hi, I tested it against the internal dev cerberus with our "private" go cli tool (github.nike.com/elc-techops/cerberus-cli, with the forked code in vendor dir).
|
…d couple missing body close to avoid potential leaks Signed-off-by: Pierre Poissinger <pierre.poissinger@nike.com>
mayitbeegh
approved these changes
Jun 21, 2018
fieldju
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pierre Poissinger pierre.poissinger@nike.com