Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node Entity Configuration #32

Merged
merged 10 commits into from
Jan 3, 2025
Merged

Update Node Entity Configuration #32

merged 10 commits into from
Jan 3, 2025

Conversation

HunorTotBagi
Copy link
Collaborator

@HunorTotBagi HunorTotBagi commented Dec 28, 2024 •
edited by NikolaVetnic
Loading

The following was accomplished in this PR:

  • Sending a request without a Title field throws an exception
  • Sending a request with Title that is longer than 100 throws an exception
  • Sending a request with Description that is longer than 500 throws an exception
  • Sending a request with Timestamp that is in the future throws an exception
  • Sending a request with Importance that is out of interval (1,10) throws an exception
  • Sending a request without a Phase field throws an exception
  • Sending a request without a Categories field throws an exception
  • Sending a request without a Tags field throws an exception

This PR closes #12

@HunorTotBagi HunorTotBagi added enhancement New feature or request backend Work performed on the backend solution labels Dec 28, 2024
@HunorTotBagi HunorTotBagi self-assigned this Dec 28, 2024
NikolaVetnic
NikolaVetnic requested changes Jan 3, 2025
View reviewed changes
Copy link
Owner

@NikolaVetnic NikolaVetnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved this by accident.

@NikolaVetnic
Copy link
Owner

NikolaVetnic commented Jan 3, 2025 •
edited
Loading

After @HunorTotBagi reviews the recent changes, let him re-request my review on the PR.

@HunorTotBagi HunorTotBagi marked this pull request as ready for review January 3, 2025 11:31
@HunorTotBagi HunorTotBagi merged commit 7885103 into main Jan 3, 2025
1 check passed
@HunorTotBagi HunorTotBagi deleted the jssbg-59_update_node_entity_configuration branch January 3, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikolaVetnic NikolaVetnic NikolaVetnic approved these changes

Assignees

@HunorTotBagi HunorTotBagi

Labels
backend Work performed on the backend solution enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Node Entity Configuration
2 participants
@HunorTotBagi @NikolaVetnic