Conversation
yurii-litvinov
left a comment
yurii-litvinov
left a comment
There was a problem hiding this comment.
Почти ничего не сделано и вообще ничего не работает, но запускается хоть :)
|
|
||
| using System.ComponentModel.DataAnnotations.Schema; | ||
|
|
||
| public class Assembly |
There was a problem hiding this comment.
Комментариев глобально не хватает.
| public int AssemblyId { get; set; } | ||
|
|
||
| [Column("name")] | ||
| public string Name { get; set; } |
There was a problem hiding this comment.
Nullability-анализ недоволен происходящим, тут и ниже. Если эти данные могут приходить извне, возможно, стоило поля явно nullable сделать.
Comment on lines
+24
to
+25
| // Add new record to db | ||
| // |
|
|
||
| public List<Data.Assembly> GetAssemblies(int assemblyCount = -1) | ||
| { | ||
| using var context = new TestingDataDbContext(new DbContextOptions<TestingDataDbContext>()); |
There was a problem hiding this comment.
Тут должно было бы быть получение сконфигурированного контекста из контейнера, а не создание нового с пустой конфигурацией. Падает так, при попытке перейти на вкладку History
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.