Nimble Combat System (NCS) by 7D7D · Pull Request #313 · Nimble-Co/FoundryVTT-Nimble

7D7D · 2026-02-16T03:47:23Z

See latest comment for massive UPDATE

🎥 Minion Group Mode Demo

Click the image below to watch:

PR Summary (Updated)

This PR adds full minion-only grouping support to the Combat Tracker so grouped minions share one turn slot, while still preserving per-minion state and management. It is focused on turn order and activation flow only (no grouped attack roll mechanics).

Key functionality delivered

Added minion grouping data model and helpers in minionGrouping.ts.
Grouping is restricted to actor type minion in both UI and document logic.
Grouped minions share initiative/sort and collapse into a single visible turn entry (leader only) via setupTurns() in combat.svelte.ts.
Added group operations on NimbleCombat:
- createMinionGroup
- addMinionsToGroup
- removeMinionsFromGroups
- dissolveMinionGroups
Preserved individual minion tracking while grouped (defeated state, remove/kill member actions, token identity).
Added persistent group lettering (A, B, C...) with monotonic progression and no reuse while groups still exist.
Added reset-to-A behavior when:
- Ungroup All is used, or
- the last remaining group is dissolved.
Added stable member numbering (G#) so existing members keep their IDs (example: A1, A3 stay; next added becomes A4).

Turn-order and reordering stability fixes

Added turn-index normalization/sync safeguards in combat.svelte.ts:
- #syncTurnIndexWithAliveTurns
- #syncTurnToCombatant
Ensures next actor stays correct after:
- grouping/ungrouping,
- adding active minion to a group,
- GM drag reorder,
- player-owned character reorder.
Added/updated tests covering these edge cases in combat.svelte.test.ts.

UI/UX additions and refinements

Group Mode workflow in CombatTracker.svelte + _combat-tracker.scss.
Selected card visual highlight for minion selection.
Group card badges now show:
- group letter (bottom-left),
- member count (xN, bottom-right).
Floating group popover:
- anchored to the right of the group card,
- auto-sized to show all members,
- stays open during member remove actions.
Added per-member Kill action in popover (GM):
- sets HP to 0,
- marks combatant defeated,
- refreshes live (optimistic + follow-up refresh).
Added token overlays for grouped minions in scene via minionGroupTokenBadges.ts:
- top-right G# badge (for example A3),
- removed automatically when ungrouped/dissolved,
- improved text resolution.

Most recent popover changes (since prior summary)

Popover title typography updated to match combat tracker button style and improved readability.
Popover title text size increased and centered both horizontally and vertically.
Removed popover table header row entirely.
Removed popover status column.
Popover now shows compact member rows with G#, Member, Remove, Kill.

Group button logic and scenarios

Control	Visibility/Enablement	Action	Typical scenario
Group Mode	Always visible (GM). Active = green.	Toggles minion grouping selection mode.	Enter/exit grouping workflow.
Clear	Visible while Group Mode is on. Disabled when nothing selected.	Clears current selected combatants.	Reset selection without leaving Group Mode.
Create Group	Shown only when selected contains 2+ ungrouped minions and no grouped selections.	Creates new group with shared turn and next letter.	Build a fresh minion pack.
Add to Group	Shown only when exactly one target group is selected plus at least one ungrouped minion.	Adds selected minions into that existing group.	Reinforce an existing pack.
Ungroup All	Shown when any minion groups exist.	Dissolves all groups in tracker; resets letter counter when none remain.	Fast global reset.
Dissolve	Shown when selection includes grouped minions (selected groups resolvable).	Dissolves selected groups only.	Remove specific groups without touching others.
Popover Remove	GM-only, per member.	Removes that minion from group; popover stays open.	Pull one minion out for independent turn tracking.
Popover Kill	GM-only, per member; disabled if already dead.	Sets HP to 0 and defeats minion (live UI update).	Instantly defeat a specific minion.
Popover Dissolve Group	GM-only in popover footer.	Dissolves the hovered group only.	Quick per-group teardown.

7D7D · 2026-02-16T16:44:23Z

Got feedback from @DoubleKing-Prime and @trevlar

Feedback/Reviews:
I think we need to be able to intuitively and quickly group and ungroup minions. If they are in a group, that means that they also all roll together when attacking. It would be nice to have a way to roll the attacks for those monsters together.
I think selecting/grouping minions on the token layer would be more intuitive than in the combat tracker.

Can you group them by selecting them on the map. Either drag-selecting them or just ctrl-selecting?I was just thinking that I think the way most people will default to trying to do it is multi-selecting, and then looking for a button to group them.

Working on a few different options starting with the plan below:

Option 1: Canvas "Group Selected" Action Bar

Use native token multi-select (drag-box or ctrl/shift multi-select, whatever Foundry keybinds are active).
When GM has token layer active and selects minion tokens, show a small floating action bar on canvas:
Group Selected appears when 2+ ungrouped minions are selected.
Add to Group appears when selection includes ungrouped minions plus exactly 1 existing group.
Remove from Group appears when grouped minions are selected.
Dissolve Group appears when one or more grouped minions are selected.
Clear Selection always available.
This should call your existing combat methods so tracker + map stay perfectly in sync.

Why this is best:

Fastest path for users.
Matches "multi-select then click button" expectation.
No mode-switch confusion.

Fronix · 2026-02-16T16:56:09Z

@7D7D

Based on the feedback, I would like an additional way to add minions to groups:

Click "Group mode"
Have it ask you to select minions on the canvas (click, drag to multi select etc works here) and only minions are selectable.
You select the minions you want in the group
Click "Create Group"
During the selection the "Group mode" can transform into a "Selected minions {number}"

The option you suggested option could be added as well, they are not mutually exclusive.

Edit: Not sure if your option had this in mind but either way. I don't like it when UI:s aren't clear about what I'm doing, since there is so much stuff on the canvas during combat it should be very clear when you are "in group mode". I know dnd5e has this issue where grouping is very unintuitive and many times we've had monsters being grouped without it being clear and it's also a hassle to remove it.

7D7D · 2026-02-16T16:59:03Z

@7D7D

Based on the feedback, I would like an additional way to add minions to groups:

Click "Group mode"

Have it ask you to select minions on the canvas (click, drag to multi select etc works here) and only minions are selectable.

You select the minions you want in the group

Click "Create Group"

During the selection the "Group mode" can transform into a "Selected minions {number}"

The option you suggested option could be added as well, they are not mutually exclusive.

Agreed. We could have multiple options to fit different user preferences

Edit: I agree, we will get it dialed in so it is both intuitive and clear what it is doing.

trevlar

Fix merge conflicts

src/actions/draggable.svelte.ts

Fixed, reworking

…ints

…haracter cards they own.

7D7D · 2026-02-21T09:04:24Z

Nimble Combat System (NCS)

Introduces a GM-only Nimble Combat System Window (NCSW) on canvas for running monster combat.
NCSW supports both non-minion monsters and minions in one place.
Blue check marks are added to map tokens and combat tracker cards when actor's turn has ended that round.
Non-minions use per-monster Roll / Roll + End Turn actions.
Minions attack together as a temporary selection-based group and generate a single combined group attack chat card.
Temporary minion groups are used for turn flow, appear as grouped for the round, and auto-dissolve at round boundaries.
Added target management in NCSW (token portrait targeting, live target info popovers, action tooltips, image popovers, draggable/resizable window).
Added turn/action flow updates so used-up actors are handled consistently during progression.
Added dark/light mode styling support for NCSW and moved NCS/NCSW user-facing text to i18n.
Closing NCSW (manual close or losing token selection) now automatically clears selected targets.

Out of scope

Group defend/interpose resolution logic is not included in this PR.

Screenshots of NCS

Fronix · 2026-02-21T12:30:12Z

@7D7D awesome work here!

Just a very important note that we are not allowed to use the Nimble logo as per the 3rd party license:

You may not use the System’s art or logo but may use the Nimble compatibility logo

Either remove it or replace it with the compatibility logo found on https://nimblerpg.com/pages/creators

Fronix

A few things I'd like to see that are a bit codesmelly

The NCS window and related code should probably be named accordingly. As this looks like something we will probably build upon we should try to keep the code and related files named in such as way that's it easier to understand.

Fronix · 2026-02-21T17:16:57Z

src/utils/minionGrouping.ts

+export const MINION_GROUP_IDENTITY_COLOR_PALETTE = [
+	'#3B82F6', // A - Blue
+	'#F97316', // B - Orange
+	'#8B5CF6', // C - Violet
+	'#FACC15', // D - Yellow
+	'#06B6D4', // E - Cyan
+	'#D946EF', // F - Magenta
+] as const;


Any reason to hardcode these values like this? I'd like to se those editable

I will remove those, they were from the old system, just missed them on the clean up.

7D7D · 2026-02-21T17:18:51Z

A few things I'd like to see that are a bit codesmelly

The NCS window and related code should probably be named accordingly. As this looks like something we will probably build upon we should try to keep the code and related files named in such as way that's it easier to understand.

I did try to do that. I had to change the old names "Canvas Lite" "Group Mode" etc... but I may have missed some. If you see any let me know.

Going forward I am using:

Nimble Combat System (NCS) for the entire system
Nimble Combat System Window (NCSW) for referencing the window

Addressed naming convention

7D7D · 2026-02-22T01:04:49Z

Changed Logo to the "Nimble Compatibility Logos". I prefer the Nimble logo used on the book (that as a bonus works well in light and dark mode thanks to the black text outline). I am hoping we can get permission from Even to use that Logo instead.

I cleaned/removed old combat system code.

Improved some of the dice roll value logic for the NCS

"Nimble Compatibility Logos"

Book Nimble Logo

trevlar · 2026-02-22T03:50:24Z

src/documents/combat/combat.svelte.ts

+		await this.#syncTurnToCombatant(previousActiveCombatantId, { persist: false });
 		return updated ? [updated] : [];
 	}
 }


Scream 😱 We've got to start getting a handle on these long, complicated files. I think in the future I'll set limits on file length and function length. Essentially, keeping the total cyclomatic complexity down reduces the likelihood of bugs being introduced.

Yeah I’m trying to condense it right now. I will switch the PR to draft. I think it may be coming from the previous versions of this feature, I’m trying to make sure all the unnecessary code is actually cleaned out correctly. I’ve done a few passes

trevlar

Duplicated canCurrentUserReorderCombatant function — Defined in both combat.svelte.ts:25 and CombatTracker.svelte:94. Consider consolidating.
Test fixture refactoring — Shared fixtures were inlined into individual test files, increasing duplication.

7D7D self-assigned this Feb 16, 2026

7D7D added the combat-tracker label Feb 16, 2026

7D7D mentioned this pull request Feb 16, 2026

Combat Tracker Support for Grouping Minions into Shared Turns #310

Open

7D7D changed the base branch from main to dev February 16, 2026 03:49

trevlar previously requested changes Feb 19, 2026

View reviewed changes

7D7D force-pushed the feature/combat_tracker_group_minions branch from ec93f12 to 6321210 Compare February 19, 2026 11:48

Fronix reviewed Feb 19, 2026

View reviewed changes

src/actions/draggable.svelte.ts Show resolved Hide resolved

7D7D marked this pull request as draft February 19, 2026 16:17

7D7D changed the title ~~Combat Tracker Support for Grouping Minions into Shared Turns~~ Nimble Combat System for minions and non-minions Feb 20, 2026

7D7D added 17 commits February 20, 2026 21:47

feat(combat): initiative sorting and ordering

9232063

Initiative sorting

6fa60be

initiative/sort

a4812e8

Heroes correctly move to death zone according to wounds and not hitpo…

412a7f2

…ints

Fixed starting turn player to always be the top most player

527d770

lint check fix

3b62d99

GM can drag/reorder all active cards. Players can drag/reorder only c…

7431a8c

…haracter cards they own.

Added tests

04a44e7

End Combat modal wording updated

48883d9

Updated drag/drop permissions

ce7b1a4

Review fixes / Tracker stays open when all actors removed

cd6c0c8

minion group mode

8bab3f2

Simplified popover table

bba7679

Grouping updates

4497d26

UI adjustments

14c7a3f

Canvas Lite Version

7611343

Restore upstream combat tracker parity

f954b5f

New Nimble Combat System

ce8a31f

7D7D force-pushed the feature/combat_tracker_group_minions branch from d6ce8d6 to ce8a31f Compare February 21, 2026 06:00

Light/Dark mode and Language support

f42fd54

7D7D changed the title ~~Nimble Combat System for minions and non-minions~~ Nimble Combat System (NCS) Feb 21, 2026

Format Code

4a6585f

7D7D marked this pull request as ready for review February 21, 2026 09:08

Fronix previously requested changes Feb 21, 2026

View reviewed changes

Fronix reviewed Feb 21, 2026

View reviewed changes

7D7D added 2 commits February 21, 2026 17:36

Logo update / Code clean-up / tighter dice logic

0f52ca9

Logo / code clean-up / improved dice logic

318f906

Test Fix

ba37c50

trevlar reviewed Feb 22, 2026

View reviewed changes

7D7D marked this pull request as draft February 22, 2026 04:03

trevlar requested changes Feb 22, 2026

View reviewed changes

logo fixed again

3a54083

Uh oh!

Comments

Conversation

7D7D commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

See latest comment for massive UPDATE

PR Summary (Updated)

Uh oh!

7D7D commented Feb 16, 2026

Uh oh!

Fronix commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

7D7D commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trevlar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

7D7D commented Feb 21, 2026

Nimble Combat System (NCS)

Out of scope

Uh oh!

Fronix commented Feb 21, 2026

Uh oh!

Fronix left a comment

Choose a reason for hiding this comment

Uh oh!

Fronix Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

7D7D Feb 21, 2026

Choose a reason for hiding this comment

Uh oh!

7D7D commented Feb 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

7D7D commented Feb 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trevlar Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

7D7D Feb 22, 2026

Choose a reason for hiding this comment

Uh oh!

trevlar left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

7D7D commented Feb 16, 2026 •

edited

Loading

Fronix commented Feb 16, 2026 •

edited

Loading

7D7D commented Feb 16, 2026 •

edited

Loading

7D7D commented Feb 21, 2026 •

edited

Loading

7D7D commented Feb 22, 2026 •

edited

Loading