Open
Conversation
…e existing data - Introduced upcastEffect field in spell JSON files to separate upcasting effects from higher level effects. - Updated spell descriptions across various spells to include the new upcastEffect field. - Created migration script to transfer existing higherLevelEffect data to upcastEffect for tier > 0 spells. - Enhanced UI components to display upcast effects in spell cards and summary tabs. - Updated localization files to include labels for upcast effects.
…and French translations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #321
highestUnlockedSpellTiernow defaults to 9 instead of 0.upcastEffectfield separates upcast descriptions (extra mana spent) fromhigherLevelEffect(character-level scaling). Both display independently in the description editor, summary, chat card, and tooltip when populated.higherLevelEffecttoupcastEffecton world load, but only for spells with upcast scaling configured. Spells without upcast scaling keep their higher level effect untouched.Test plan
scaling.mode = 'none'keephigherLevelEffectuntouched after migrationnpx vitest run🤖 PR description generated with Claude Code