Skip to content

Surface scanner version on security tab #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgoldsborough wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Surface scanner version on security tab #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions apps/registry/src/routes/packages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,10 +607,15 @@ export const packageRoutes: FastifyPluginAsync = async (fastify) => {
remediation: (f['remediation'] as string) ?? null,
}));

// Extract scanner version from report metadata
const scanMeta = report?.['scan'] as Record<string, unknown> | undefined;
const scannerVersion = (scanMeta?.['scanner_version'] as string) ?? null;

return {
status: scan['status'],
risk_score: scan['riskScore'],
scanned_at: scan['completedAt'],
scanner_version: scannerVersion,
certification: scan['certificationLevel'] !== null ? {
level: scan['certificationLevel'],
level_name: getCertificationLevelName(scan['certificationLevel'] as number | null),
Expand Down
1 change: 1 addition & 0 deletions apps/registry/src/schemas/generated/api-responses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ export const SecurityScanSchema = z.object({
status: z.enum(['pending', 'scanning', 'completed', 'failed']),
risk_score: z.enum(['CRITICAL', 'HIGH', 'MEDIUM', 'LOW']).nullable(),
scanned_at: z.union([z.string(), z.date()]).nullable(),
scanner_version: z.string().nullable().optional(),
certification: CertificationSchema.nullable().optional(),
summary: z.object({
components: z.number(),
Expand Down
7 changes: 7 additions & 0 deletions apps/web/src/components/SecurityReportSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ interface SecurityScan {
status: 'pending' | 'scanning' | 'completed' | 'failed';
risk_score: 'CRITICAL' | 'HIGH' | 'MEDIUM' | 'LOW' | null;
scanned_at: string | Date | null;
scanner_version?: string | null;
certification?: Certification | null;
summary?: SecurityScanSummary;
scans?: Record<string, ScanResult>;
Expand Down Expand Up @@ -227,6 +228,12 @@ export default function SecurityReportSection({ securityScan, version }: Props)
)}
<span className="text-mpak-gray-300">|</span>
<span>Scanned {formatDate(securityScan.scanned_at)}</span>
{securityScan.scanner_version && (
<>
<span className="text-mpak-gray-300">|</span>
<span>Scanner v{securityScan.scanner_version}</span>
</>
)}
</div>
</div>
</div>
Expand Down
1 change: 1 addition & 0 deletions apps/web/src/schemas/generated/api-responses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ export const SecurityScanSchema = z.object({
status: z.enum(['pending', 'scanning', 'completed', 'failed']),
risk_score: z.enum(['CRITICAL', 'HIGH', 'MEDIUM', 'LOW']).nullable(),
scanned_at: z.union([z.string(), z.date()]).nullable(),
scanner_version: z.string().nullable().optional(),
certification: CertificationSchema.nullable().optional(),
summary: z.object({
components: z.number(), // Total SBOM components
Expand Down
1 change: 1 addition & 0 deletions packages/schemas/src/api-responses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ export const SecurityScanSchema = z.object({
status: z.enum(["pending", "scanning", "completed", "failed"]),
risk_score: z.enum(["CRITICAL", "HIGH", "MEDIUM", "LOW"]).nullable(),
scanned_at: z.union([z.string(), z.date()]).nullable(),
scanner_version: z.string().nullable().optional(),
certification: CertificationSchema.nullable().optional(),
summary: z
.object({
Expand Down