Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin the click version #419

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Pin the click version #419

merged 1 commit into from
Jul 17, 2023

Conversation

mmerklinger
Copy link
Contributor

@mmerklinger mmerklinger commented Jul 13, 2023

This PR limits the version of the click to a maximum of 8.1.3.
The latest version of click has a problem with mypy type checks, causing them to fail.
The issue is currently unsolved pallets/click#2558.

Changes

  • Restricts usable click version to >=8.0 and <=8.1.3.

Checklist

Make sure to run make check and make fix before creating a PR, otherwise the CI will fail.

  • tested with Python3.9
  • signed commits
  • updated documentation (e.g. parameter description, inline doc, docs.nitrokey)
  • added labels

Test Environment and Execution

  • OS:
  • device's model:
  • device's firmware version:

Relevant Output Example

Fixes #

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.1.5 is supposed to fix this but causes 121 new typing errors that all look like this:

pynitrokey/cli/__init__.py:87: error: <nothing> has no attribute "add_command"  [attr-defined]

So I’m fine with restricting to <=8.1.3. Should we keep the >=8.0?

@mmerklinger
Copy link
Contributor Author

Adapted the PR accordingly.

@robin-nitrokey robin-nitrokey merged commit 265e160 into Nitrokey:master Jul 17, 2023
5 checks passed
@mmerklinger mmerklinger deleted the fix-mypy-typing branch July 18, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants