feat: improve NetHSM API exception handling #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pynitrokey/nethsm/__init__.py
Outdated
Comment on lines
192
to
196
| # 405 "Method Not Allowed" mostly happens when the UserID or KeyID contains a character | ||
| # - that ends the path of the URL like a question mark '?' : | ||
| # /api/v1/keys/?/cert will hit the keys listing endpoint instead of the key/{KeyID}/cert endpoint | ||
| # - that doesn't cound as a phath parameter like a slash '/' : | ||
| # /api/v1/keys///cert will be interpreted as /api/v1/keys/cert with cert as the KeyID |
There was a problem hiding this comment.
Is that something that we should validate before sending the request?
There was a problem hiding this comment.
That would be the best solution yes
There was a problem hiding this comment.
Please create a ticket for it (or a PR ;)).
nponsard
force-pushed
the
pr/improve-api-exception-handling
branch
from
d34c352
to
bf6be1e
Compare
robin-nitrokey
approved these changes
Sep 21, 2023
robin-nitrokey
force-pushed
the
pr/improve-api-exception-handling
branch
from
bf6be1e
to
659b308
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the handling of API errors in the nethsm commands.
Checklist
Make sure to run
make checkandmake fixbefore creating a PR, otherwise the CI will fail.Test Environment and Execution